Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade shadcn components #1759

Closed
wants to merge 2 commits into from

Conversation

sandangel
Copy link
Contributor

Signed-off-by: San Nguyen vinhsannguyen91@gmail.com

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. frontend Pertains to the frontend. labels Jan 20, 2025
@sandangel
Copy link
Contributor Author

upgrade using command: npx shadcn@latest add -a -y -o as described here: shadcn-ui/ui#790

@willydouhard
Copy link
Collaborator

What is the goal of adding these new components like breadcrumb?

@sandangel
Copy link
Contributor Author

I have no idea, I only ran the command as described in the discussion.

@sandangel
Copy link
Contributor Author

They might be there to support additional use cases

@sandangel
Copy link
Contributor Author

I can also remove them if needed.

Signed-off-by: San Nguyen <vinhsannguyen91@gmail.com>
@sandangel sandangel force-pushed the feat/upgrade-shadcn branch from 600ef1c to 81d2db7 Compare January 20, 2025 16:20
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 20, 2025
Signed-off-by: San Nguyen <vinhsannguyen91@gmail.com>
@dokterbob dokterbob added the blocked Awaiting update or feedback from user after initial review/comments. label Jan 22, 2025
@dokterbob
Copy link
Collaborator

Marked as blocked until tests pass.

@sandangel sandangel closed this Jan 24, 2025
@sandangel sandangel deleted the feat/upgrade-shadcn branch January 24, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Awaiting update or feedback from user after initial review/comments. frontend Pertains to the frontend. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants